fix: updated get balance API to use token instead of public key as params.#30
Open
unniznd wants to merge 1 commit intolighthouse-web3:mainfrom
Open
fix: updated get balance API to use token instead of public key as params.#30unniznd wants to merge 1 commit intolighthouse-web3:mainfrom
unniznd wants to merge 1 commit intolighthouse-web3:mainfrom
Conversation
Member
|
/describe |
Titlefix: updated get balance API to use token instead of public key as params. User descriptionWhat have I changedFixed the get balance API to use the token instead of the public key as params Why have I changedSince get balance API uses token instead of public key. PR TypeBug fix Description
Diagram Walkthroughflowchart LR
A["Old API"] -- "publicKey param" --> B["Authentication"]
C["New API"] -- "Bearer token" --> B["Authentication"]
B --> D["Balance Data"]
|
| Relevant files | |||
|---|---|---|---|
| Bug fix |
|
Author
|
I found that the balance is currently determined using the token, not according to the public key passed as parameters. I have therefore modified the API portion to achieve this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What have I changed
Fixed the get balance API to use the token instead of the public key as params
Why have I changed
Since get balance API uses token instead of public key.